-
Notifications
You must be signed in to change notification settings - Fork 61.6k
Remove incorrect note about allowed TXT record removal #37213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
After removing the TXT record I got an e-mail: > We are unable to find a verification TXT record on yoursite.com. Please verify your domain within 7 days by following our instructions before it becomes unverified. and I deleted the record based on this line. Thus I believe it to be not correct.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the documentation for verifying or approving a domain for your organization. The change removes the instruction suggesting the deletion of the TXT record after achieving domain verification, which appears to have unintended consequences.
Comments suppressed due to low confidence (1)
content/organizations/managing-organization-settings/verifying-or-approving-a-domain-for-your-organization.md:80
- Removing this instruction should help prevent potential unintended consequences like triggering an unexpected email. Please ensure the documentation clearly states the TXT record should remain to avoid verification issues.
-1. Optionally, once the "Verified" badge is visible on your organization's profile page, you can delete the TXT entry from the DNS record at your domain hosting service.
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksThe table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
Thanks so much for opening a PR! I'll get this triaged for review |
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
@martinpaljak Okay, I tracked down the team that owns this feature, and they're going to look into it. Since it's not our Docs team, I have no idea if they'll use this PR, but I'm going to leave it open so they can reference it and use it if they want to. Thank you so much for being patient! 💛 This one was a bit of a puzzle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "We are unable to find a verification TXT record on" message is not for the verifiable domains feature, it is for the GitHub Pages feature.
See:
Why:
After removing the TXT record of a domain I got an e-mail in a few days:
and I deleted the record based on this line. Thus I believe it to be not correct.
Check off the following: